Allow Android rendering mode (hardware/software) to be controlled via a prop #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… a prop By default hardware rendering mode will be used, however if you want to animate your mask you'll need to opt into software rendering.
FonDorn approved these changes Jul 13, 2021
Collaborator
| @Naturalclar what do you think? Can we go ahead and merge this changes? |
| @levibuzolic Thanks for this PR! I used this PR, set the |
Contributor Author
| @hannojg after shipping this change in our app, we've found that some devices don't support it or are forcing hardware rendering mode. This appears to be very common on Huawei devices, but we've also seen reports from a few others. At this stage we haven't been able to find a solution for this. |
| @hannojg @levibuzolic I had the same issue but setting the |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#116 improved performance, but disabled the ability to animate the mask on Android. This PR introduces a new property
androidRenderingModewhich allows the user to choose the rendering mode should they require the ability to animate the mask element and are willing to accept the performance trade-off.Ideally a way to animate the mask while keeping performance good can be found, but until then this seems like a reasonable compromise.
Fixes #117