Skip to content

Fix jsonSerialize Deprecation Notice #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
othercorey merged 1 commit into from
Mar 13, 2022
Merged

Fix jsonSerialize Deprecation Notice #74

othercorey merged 1 commit into from
Mar 13, 2022

Conversation

@amayer5125
Copy link
Contributor

@amayer5125 amayer5125 commented Mar 13, 2022

This fixes the notice I get when running the queue worker on PHP 8.1.

Notice: Deprecated (8192): Return type of Cake\Queue\Job\Message::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
othercorey
othercorey reviewed Mar 13, 2022
View reviewed changes
src/Job/Message.php Outdated
* @return mixed
*/
public function jsonSerialize()
public function jsonSerialize(): mixed
Copy link
Member

@othercorey othercorey Mar 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the \ReturnTypeWillChange attribute instead to support PHP 7.
@othercorey othercorey added this to the 1.0.0 milestone Mar 13, 2022
@othercorey othercorey merged commit aed83ab into cakephp:master Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@amayer5125 @othercorey