Update ruleset.xml #381
Merged
Update ruleset.xml #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
v5 is not allowing slevomat/coding-standard v6 and it's giving deprecation errors in newer versions of php. Deprecated: Creation of dynamic property SlevomatCodingStandard\Sniffs\TypeHints\DeclareStrictTypesSniff::$newlinesCountAfterDeclare is deprecated
This 5.x branch uses I haven't encountered any errors using |
| Sorry I misunderstood, thank you for the report. I have removed the defunct props for 5.x in 4728b69. |
| Yes but the ruleset makes use of Settings Not available in V8. These lead to deprecarion warnings (If enabled) in PHP8.2. |
They have been removed now 4728b69 |
| There is one more (See my second commit) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
v5 is not allowing slevomat/coding-standard v6 and it's giving deprecation errors in newer versions of php.
Deprecated: Creation of dynamic property SlevomatCodingStandard\Sniffs\TypeHints\DeclareStrictTypesSniff::$newlinesCountAfterDeclare is deprecated
ref: squizlabs/PHP_CodeSniffer#3629 (comment)
the propertytypehint sniff has no enableStaticTypeHint option:
https://github.com/slevomat/coding-standard/blob/master/SlevomatCodingStandard/Sniffs/TypeHints/PropertyTypeHintSniff.php#L68