fix: single-connection mode connection reestablishment #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Previously there was no logic to handle an existing connection that was e.g. closed, so that was added in in this commit along with a corresponding test.
ctrlaltf24 reviewed Sep 5, 2024
ctrlaltf24 reviewed Sep 9, 2024
tacacs-plus/src/inner.rs Outdated
| }); | ||
| | ||
| // wait for server to bind to address | ||
| notify.notified().await; |
There was a problem hiding this comment.
these are nice to coordinate between threads (especially in tests)
| }, | ||
| | ||
| // if there's data still available, the connection is still open, although | ||
| // this shouldn't happen in the context of TACACS+ |
There was a problem hiding this comment.
nit: should be debug/trace log here? Would this be possible to hit in a multi-threaded context? Or would it hit the mutex lock?
There was a problem hiding this comment.
It should be prevented by the mutex since it's locked for the full session within Client
ctrlaltf24 approved these changes Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously there was no logic to handle an existing connection that was e.g. closed. This PR handles that case by attempting to read from the underlying connection before writing to it, and reestablishing on an EOF condition or specific errors.
Single-connection mode was also enabled on the TACACS+ NG test server image, since I didn't realize it wasn't enabled by default.
Fixes #38