Improved performance by eliminating String creation by utilizing the original &str slice. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
eliminate `String` creation by utilizing the original &str slice
hyunsik approved these changes Aug 23, 2023
Member
hyunsik left a comment
hyunsik left a comment There was a problem hiding this comment.
The PR looks great to me. Thank you for your contribution.
Contributor Author
| Thank you for merging. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi @hyunsik
Thank you for developing such a great crate!
I wanted to contribute to this crate in any way I could, so I made some changes to improve performance.
This change also helps support no_std in issue #3