support _initialize export as well as __wasm_call_ctors #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Per WebAssembly/tool-conventions#203 and recent LLVM and wasi-libc changes, libraries may export an `_initialize` function instead of `__wasm_call_ctors`, and we should call whichever one we find. Note that we expect to find at most one of the two, and will return an error if both are found. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton approved these changes Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Per WebAssembly/tool-conventions#203 and recent LLVM and wasi-libc changes, libraries may export an
_initializefunction instead of__wasm_call_ctors, and we should call whichever one we find. Note that we expect to find at most one of the two, and will return an error if both are found.