default maxpendtime set for 1 day #1595
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR will enforce we have a default maxpendtime set for 1 day. This address bug in #1593 reported by @karcaw. I can confirm this error is present in codebase. I was able to reproduce this error when submitting a job. We can test this feature by holding the job permanently so add
-H.Here is an example on Perlmutter
When building this test it was polling every 30sec and will continue to poll till it reaches 1 day. Shown below is output of the run phase
When one specifies
--maxpendtimeon the command line this value is honored and has the highest precendenceNow i added
maxpendtimein the configuration file this will be underdefaultskeyword shown be is a sample configuration on PerlmutterNow if i run this without specifying
--maxpendtimeit will take the value of the configuration file. Note we should have this test cancel at 60s since we poll every 30s and maxpendtime hasnt reached