Server: Append injected scripts to body instead of head #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Any setup that loads QUnit in the body instead of head will timeout out otherwise.
| @browserstack @nakula @rahulnwn @ritesharora can this land? Anything on the other issues? |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Any setup that loads QUnit in the body instead of head will timeout out otherwise.
I ran into this while integrating browserstack-runner with Globalize. The unit testsuite there has a different setup which currently causes a timeout, even though the tests pass just fine.
I briefly looked at the
testsfolder to see if I can add or modify something there. Some pointers would be useful there. Feel free to include the Globalize test suite there, that would be a good testcase for QUnit+requirejs.