Use conditional tag matching logic everywhere #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pulkitsharma07 approved these changes Dec 6, 2017
cwisecarver force-pushed the bugfix/fix-matcher-logic branch from 9edd37a to 0c8a560 Compare | @pulkitsharma07 Updated to merge cleanly. |
cwisecarver force-pushed the bugfix/fix-matcher-logic branch from 0c8a560 to c584dd5 Compare 
JakeChampion approved these changes Jan 28, 2020
yashLadha approved these changes Jan 29, 2020
francisf approved these changes Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The logic to match a tag depending on test framework was not consistent when using the test_server configuration option. It would always search for
</head>and replace that with</body>if the framework was not mocha. This PR puts that logic into a function and uses it in both places.