Specify ruby version in Gemfile instead of a named rvm installation #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits January 24, 2014 10:02
Contributor Author
| So it appears I set up this pull request to point to the branch and not the commit, which means it has also updated to include the next pull I was going to suggest. I'm not 100% sure what other library we were using that defined $ but it was causing conflicts with the BCMS library. I've updated some of the BCMS JS to overtly use jQuery instead of relying on $ always being jQuery. |
peakpg added a commit that referenced this pull request Jan 30, 2014
* Specify ruby version in Gemfile instead of a named rvm installation. * Wrap JQuery ready functions to avoid conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A small tweak for the ruby version - I'm using chruby and happen to have named my ruby 2.0.0 installation 'ruby200' instead of '2.0.0'. My goal here is to move the soft requirement of a matching ruby installation name into an explicit ruby version requirement in the Gemfile.
See http://bundler.io/v1.2/gemfile_ruby.html for the ruby declaration, bundle check will report
if the current ruby version does not match.