Fix race condition which causes output to be lost sometimes #67
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There seems to be a race condition which can cause stdout/stderr output to be missed. I noticed this when a simple
printf("Hello world\n")program would sometimes fail to print.It happens when the final call to
p.write_contents()happens indo_execute. At this time, the threadsRealTimeSubprocess._stdout_threadandRealTimeSubprocess._stderr_threadmay not have finished reading all the output.To fix this, we call
.joinon both threads before the finalp.write_contents().