Dockerize System Tests #710
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@donv very nicely added system tests that generate screenshots for the
README. This PR adds support to the optional Docker and Docker Compose files so that the system tests can be run in Docker.The intent is to ensure that system tests can still be run without Docker, but that they will also run for those who prefer to develop in a Docker environment, because they want to isolate their development work, or for whatever other reason.
This PR introduces a new Docker Compose file:
docker-compose-system-test.yml. This file uses a standard Selenium image for Chrome to run the browser. Part of the reason for a separate file is the currentdocker-compose.ymlresults in smaller containers, since it doesn't have the full browser. I also wanted to try things in a completely separate file, to avoid breaking the existing Docker workflow.The approach in this PR is highly experimental and includes some rough edges:
root. There may be a simple fix for this, but I haven't tried it yet.