Rendering input with bootstrap but without wrapper

[yevhene]

Useful when real field value specified indirectly:

f.form_group :user do f.email_field :email, wrapper: false end

[mattbrictson]

Hi, thanks for the PR! Bonus points for the included unit test. Awesome. 👍

I'm considering merging this but first I want to understand a little more about your use case. Could you give a more detailed example/explanation of why this new feature is useful?

[gradybarrett]

@mattbrictson, I think this feature could be used to address issue 89. Unless there's a better way to solve that issue.

[mattbrictson]

I think this feature could be used to address issue 89

Good point!

[mattbrictson]

@yevhene Could you update this PR with a CHANGELOG entry? Thanks!

[yevhene]

@mattbrictson done

[mattbrictson]

Hmm, looks like there are some test failures in Travis (above and beyond the known issue in #329).

E.g. https://travis-ci.org/bootstrap-ruby/rails-bootstrap-forms/jobs/229914661

 1) Failure: BootstrapFormGroupTest#test_rendering_without_wrapper [/home/travis/build/bootstrap-ruby/rails-bootstrap-forms/test/bootstrap_form_group_test.rb:250]: --- expected +++ actual @@ -1 +1 @@ -"<input class=\"form-control\" id=\"user_email\" name=\"user[email]\" type=\"text\" value=\"steve@example.com\" />" +"<input class=\"form-control\" type=\"text\" value=\"steve@example.com\" name=\"user[email]\" id=\"user_email\" />" 

@yevhene Can you rebase on the latest master and also update your test to use assert_equivalent_xml instead of assert_equal? I think that should fix it.

Thanks for your help! 🙇

[yevhene]

@mattbrictson done

[yevhene]

@mattbrictson I don't understand what CI wants now.

[mattbrictson]

Like I said, it is the known problem reported in #329. Don't worry about it! Thanks

[medir]

Is there any plan to integrate this feature into the next version? It fits perfect to my issue :) ty

[lcreid]

Thanks for bringing this to my attention. It sounds worthwhile. Apologies that we haven't merged it already. I will look into it and see what we can do.

[lcreid]

Closing and re-opening to force a re-run of Travis.

[lcreid]

Reopen to force Travis. FYI: The reason I had to close and re-open is because we changed the name of the repository last year. If we hadn't changed the number, I would have been able to simply re-run the build in Travis.

[lcreid]

@yevhene would you please add documentation to the README.md describing the :wrapper option, and fix the RuboCop offences. You can see the RuboCop offences in the last build of the Travis run. If you're not interested feel free to say so and we'll do it.

I'll look into the Travis failures for the runs against the old version of Ruby, unless someone fixes it before I can get to it.

[lcreid]

Trying the "close-reopen" trick again to see if the Travis build has been fixed.

[lcreid]

The Travis failure is fixed now.