Skip to content

Conversation

@invke
Copy link
Contributor

@invke invke commented Nov 14, 2019

Setting up eslint config for the boost-styles.

I've set it to use Standard. The other option was recommended, but from my experience in FinCap, it barely lint's anything.

TODO:

  • It should use extends: in the eslintrc.yml instead of just copying it in (if we w=can).
  • I still need to add in the how to use message.
  • The file inclusions/exclusions probably need to be done.
  • Add enforce semicolons as default, as more people prefer that.
    That said, I think they're useless extra syntax — and am waiting for someone to change my mind
@invke invke self-assigned this Nov 14, 2019
@hapiben hapiben self-requested a review December 3, 2019 00:29
Copy link
Member

@hapiben hapiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good bro.

@hapiben hapiben requested a review from yarhtut December 12, 2019 20:46
Copy link
Contributor

@yarhtut yarhtut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@hapiben hapiben merged commit cc87f53 into master Jan 23, 2020
@hapiben hapiben deleted the eslint-standard branch January 23, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants