Skip to content

Conversation

@soniyadotp
Copy link
Contributor

@soniyadotp soniyadotp commented Oct 8, 2023

What type of PR is this? (check all applicable)

Fixes #136
'This PR is the translation of the first five chapters of the book INTODUCTION TO BASH SCRIPTING in HINDI LANGUAGE

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Added to documentation?

Yes

  • 📜 Tranlation of the book
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

@what-the-diff
Copy link

what-the-diff bot commented Oct 8, 2023

PR Summary

  • Inclusion of Table of Contents
    A new file called "00.Table_of_Contents.md" has been added providing a clear roadmap of the content within the ebook, specifically tailored for a Hindi audience.
  • Introduction of Book and Author
    The file "01.About_the_Book.md" has been introduced, which offers detailed context about both the book and its respected author.
  • Bash Scripting Introduction
    We've added "02.Introduction_to_Bash_scripting.md" file which serves as an introductory guide to bash scripting, a powerful tool for automating tasks in programming.
  • Understanding Bash Structure
    The added "03.Bash_Structure.md" file illustrates the structural elements of bash scripts aiding users to comprehend their functionality better.
  • First Bash Script Example
    The new "04.Bash_Hello_World.md" file presents new users with a basic "Hello World!" bash script example to assist in their learning journey.
  • Elaboration on Bash Variables
    Lastly, "05.Bash_Variables.md" file which has been added, offers an insight into the use of variables within bash scripting.
@soniyadotp soniyadotp changed the title Translation of First Five chapters of this book in HINDI llanguage Translation of First Five chapters of this book in HINDI language Oct 8, 2023
@soniyadotp soniyadotp changed the title Translation of First Five chapters of this book in HINDI language Translation of First Five chapters of this book in HINDI language fix issue #136 Oct 8, 2023
Copy link
Owner

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! Would you mind renaming the files so that they keep the exact same naming convention as the other translations, eg:

image
@soniyadotp
Copy link
Contributor Author

Sure

@soniyadotp soniyadotp changed the title Translation of First Five chapters of this book in HINDI language fix issue #136 Translation of First Five chapters of this book in HINDI language fix issue #136 (changes-made) Oct 9, 2023
@soniyadotp
Copy link
Contributor Author

@bobbyiliev Is it okay now?

Copy link
Owner

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Is it OK if we go ahead and delete the old files as well as they will not be picked up by the Ibis tool when the PDF is built:

image
@soniyadotp
Copy link
Contributor Author

@bobbyiliev changes are made successfully. Do checkOut!

Copy link
Owner

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution!

@bobbyiliev bobbyiliev merged commit ad309f6 into bobbyiliev:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants