PDF file download link fix #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Hello, when the pdf file download link is clicked instead of downloading it, the user is directed to the GitHub page. So Instead of that I directly pointed them to the raw files so when the download button is clicked the files are directly downloaded, skipping the extra step. Just a minor inconvenience.
bobbyiliev reviewed Oct 26, 2022
Owner
bobbyiliev left a comment
bobbyiliev left a comment There was a problem hiding this comment.
Thank you for this, but I think that it works well as it is, that way people could do a quick preview of the ebook before downloading it directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Hello, when the pdf file download link is clicked instead of downloading it, the user is directed to the GitHub page. So Instead of that I directly pointed them to the raw files so when the download button is clicked the files are directly downloaded, skipping the extra step. Just a minor inconvenience. If you like it you can go ahead and merge it into your project😊
Thank You!
Added to documentation?