closes issues #48 #47 #46 #41 - Diff in array not working #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TicaTac changed the title TicaTac changed the title 
justspamjustin requested changes May 21, 2018
js/main.js Outdated
| if (!leftJson || !rightJson) return; | ||
| var diffs = jsonpatch.compare(leftJson, rightJson); | ||
| window.diff = diffs; | ||
| // debugger; |
There was a problem hiding this comment.
Please remove this debugger comment.
| @justspamjustin |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
added a small fix : when comparing arrays, we want to get the start position to highlight.
the path points at a 'value' but there isn't a 'key'.
this wasn't handled previously, causing arrays to not be highlighted for changes.
since the start position was empty - the codemirror didn't highlight the change at all.
also renamed the color parameter to 'color' (was 'class-name')
renamed the path received from the diff to 'path' (was 'key')