First pass at fixing applyZOrder #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ct-native-twilio-video-webrtc into Add-applyZOrder-prop
| What's the status of this @slycoder ? |
Collaborator Author
| Looking for feedback on whether this solves people's issues and is working as expected in which case I'll merge to master. |
| @slycoder can you please put scaleType on android? |
Collaborator Author
| scaleType should exist on android already; it supports the values fit and fill. |
JoshuaChan-Fee pushed a commit to hinge-health/react-native-twilio-video-webrtc that referenced this pull request Dec 20, 2022
* First pass at fixing applyZOrder * Cleanup using defaults * Fix return types * Fix import * Fix dupe import
rajangargsmartdata pushed a commit to rajangargsmartdata/react-native-twilio-video-webrtc that referenced this pull request Mar 20, 2025
* First pass at fixing applyZOrder * Cleanup using defaults * Fix return types * Fix import * Fix dupe import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #224
This adds a new prop on android called applyZOrder which controls the z-ordering of views. The defaults have been set so as to maintain the current behavior.