Deprecate HubInstance #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Many of the new issues an outstanding issues relate to Hub Instance which we have previously discussed deprecating in favour of the client interface. Instead of forcing a hard switch, I'm proposing that we instead opt for a phased approach, starting with our examples directory: * Any new or modified examples/scripts should make use of the client interface, * Any issues related to examples/scripts using Hub Instance should be closed as `Won't Fix`
mkumykov approved these changes Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Many of the new issues an outstanding issues relate to
HubInstancewhich has been superseded by theclientinterface. Perhaps it is time to deprecate HubInstance?Instead of forcing a hard switch, I'm proposing that we instead opt for a phased approach, starting with our examples directory:
clientinterface,HubInstanceshould be closed asWon't FixHubInstance, once it'sclientequivalent is created.