Increase default page_size #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Page size of 100 was far too conservative. 1000 will dramatically improve exec times for most users, whilst remaining manageable for resources with many results.
| Hmm, do you have any timings on how long typical queries take with 1000 elements? I choose 100 for projects, versions, codelocations, etc. as it took approximately 2-3 seconds (this was for HubInstance) to return when hitting a moderately loaded hosted server. I think that a page size where common queries return in under 5 (up to 10?) seconds tops is a potential goal. Anyway on my side I'll give Sage a whirl with the 1000 default and see how some of our servers respond. |
Average time taken to get 1000 items, with varying page sizes: page_size | Local to Blackduck 100 | 18.878 150 | 16.700 200 | 15.696 250 | 13.675 500 | 13.702 1000 | 13.736
OffBy0x01 changed the title | I did some testing on my end (Sage works fine either way). Completely open to upping the limit to whatever makes sense. |
skiyooka approved these changes May 19, 2021
| I've updated this and merged it in as I would like to publish a new version of hub-rest-api-python to include this and the bearer token renewal fix. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Page size of 100 was far too conservative. 250 will dramatically improve exec times for most users, whilst remaining manageable for resources with many results.
Average (of 10) time taken to get 1000 items, with varying page sizes:
page_size | Local to Blackduck
100 | 18.878
150 | 16.700
200 | 15.696
250 | 13.675
500 | 13.702
1000 | 13.736