modified calling function get_user_by_id to use correct parameters as… #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… defined in get_user_by_url
gsnyder2007 approved these changes Jan 8, 2021
Contributor
gsnyder2007 left a comment
gsnyder2007 left a comment There was a problem hiding this comment.
This is an area of the library that probably deserves a makeover. The change proposed works - I tested it - in that the call to get_user_by_url will end up using the media type specified in get_user_by_url. Arguably, the use of the hard-coded (and now perhaps old) media type is a defect in get_user_by_url. But that shouldn't stand in the way of merging the change so I"m approving this and will merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
… defined in get_user_by_url