Split HubRestApi mega-class into multiple files #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
| Forgot to add; I made HubInstance directly importable by adding it to init.py: |
Collaborator Author
| @gsnyder2007 had a thought this morning - it might make more sense to leave |
gsnyder2007 approved these changes Mar 27, 2021
Contributor
gsnyder2007 left a comment
gsnyder2007 left a comment There was a problem hiding this comment.
After discussions with a number of contribors to hub-rest-api-python we have agreed to move forward on this PR and PR 129. So, I'm going to merge this PR 127, and also PR 129, do regression testing to ensure nothing is broken and prepare a v1 of blackduck for TestPyPi and then after more testing will push to PyPi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently HubRestApi is massive, and subsequently getLogger(name) isn't being used to it's full potential. This PR splits HubRestAPI into numerous smaller files, each with a name denoting the types of functions contained within i.e.
Roles.pycontainsget_roles_url_from_user_or_group(among others).First pull request of many from me - backporting changes I made during a year long client engagement.