Wait for multiple code locations e.g. BDIO, Signature and Snippet scanning #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…performing BOM scans esepcially without aggregating. Will wait for all code locations to complete, modified snippet scan wait criteria to only apply to relevant code locations
gsnyder2007 approved these changes Nov 30, 2020
Contributor
gsnyder2007 left a comment
gsnyder2007 left a comment There was a problem hiding this comment.
Looks good, thanks for the contribution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This was at the request of a customer. Previously this would wait for the first matching code location and ignore the others. When using package manager scan as well as signature scan you will get at least 2 code locations. If you then also snippet scan one of these code locations (* scan) will have 2 scans, one FS and one SNIPPET.
Modified the wait code to wait for all matching code locations. This involved also modifying the code that determines if there should be a snippet scan to wait for too, as BDIO scans will not have a second SNIPPET scan.
Tested thoroughly and the only scenario it does not handle is if there are previous code location names that also match e.g. '<code_location_name> bdio 21' when this current scan only includes 20 bdio scans. In this scenario it will wait and timeout for 21 to have a 'newer' scan. The flip side of this is if we ignore code locations without newer scans then perhaps we say it is finished when it hasn't been created yet. Food for thought.