Skip to content

Conversation

@Schow94
Copy link
Contributor

@Schow94 Schow94 commented Oct 23, 2022

No description provided.

@Schow94 Schow94 mentioned this pull request Oct 23, 2022
Copy link
Owner

@bitfield bitfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Schow94 and others added 2 commits November 2, 2022 08:49
Co-authored-by: John Arundel <john@bitfieldconsulting.com>
@bitfield
Copy link
Owner

bitfield commented Nov 2, 2022

Nice work @Schow94! I have a question: is there a special reason for the Code of Conduct to be in a .github subfolder? Does that have some special meaning to GitHub? Otherwise I would probably have put it in the root folder next to the CONTRIBUTING guide, for example.

@Schow94
Copy link
Contributor Author

Schow94 commented Nov 16, 2022

I saw that on another project, but I can move it to the project root folder if preferred. I don't see any reason why it needs to be in .github subfolder.

@bitfield
Copy link
Owner

Yes, I think that'll make it easier to find. This page shows it being added to the root folder.

@Schow94
Copy link
Contributor Author

Schow94 commented Nov 16, 2022

That makes sense. I've moved it to the project root!

@bitfield bitfield merged commit dbe8ad2 into bitfield:master Nov 16, 2022
@bitfield
Copy link
Owner

Nice work @Schow94! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants