Use crypto-js as a module from npm #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This is great, and I think we should pull this in! I'm getting a failing test due to global leaks on the Not sure how to fix that one. |
| My bad. Only ran the tests with |
weilu added a commit that referenced this pull request Mar 11, 2014
Use crypto-js as a module from npm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Current crypto-js is partially ported from 2.0.0 and partially ported from 3.2.1(modified to use 2.0.0's interface). The npm crypto-js module is up-to-date. I hope to get the benefit of bug fixes & features from upstream by using the module. Also, applications that uses bitcoinjs-lib and cryto-js do not have to worry about two different implementations for the same set of cryto functions.
The downside of the module is that the source is uglified, so it isn't very debugging friendly.
@abrkn @kyledrake thoughts?