More address testing #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| In case the constructor is invoked without var Foo = function(){ console.log(this) } Foo() // Window new Foo() // Foo {} |
louisinger added a commit to louisinger/liquidjs-lib that referenced this pull request Jun 9, 2022
* wip split SHA256 functions * fix and test witnessHashV1 * yarn test * strict equality * rename hashOutpoints -> hashPrevouts * yarn test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Moves testing coverage to 100%, except for this line: https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/src/address.js#L8
Can someone explain what this line is used for? I think it has something to do with inheritance, but I just need a use case for it. If it doesn't make sense I will remove it.