Skip to content

Conversation

@kyledrake
Copy link
Contributor

This completes the testing for Address.

The one case I didn't test is for this line: https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/src/address.js#L8

Can someone explain the purpose of this line of code to me?

@kyledrake
Copy link
Contributor Author

I'm fixing the spacing and adding another commit, ignore this pull

@kyledrake kyledrake closed this Mar 6, 2014
@abrkn
Copy link
Contributor

abrkn commented Mar 7, 2014

Again I think the constructor is too flexible. Drop the:

 if (!(this instanceof Address)) { return new Address(bytes, version); } if (arguments[0] instanceof Address) { this.hash = arguments[0].hash; this.version = arguments[0].version; }

All these cloning functions are unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants