Update sine test #97
Merged
Update sine test #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
matas-bitbybit-dev approved these changes Oct 24, 2025
Contributor
matas-bitbybit-dev left a comment
matas-bitbybit-dev left a comment There was a problem hiding this comment.
Looks great, thanks for submitting! Shx worked on github actions running nodejs in ubuntu, I'm happy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Test was failing, maybe its just a windows issue.
Expected: 0.4539904997395468
Received: 0.45399049973954675
I changed to use toBeCloseTo, the value could be changed if it is also that value on Linux systems?