Allow php-parser 5.x #108
Merged
Allow php-parser 5.x #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
5.0 had some breaking changes, but it improves pretty printing and lots of packages in the php ecosystem already support it:
This pr changes the requirements to also allow 5.x versions, while preserving backwards compatibility for lower versions.
On 5.x the new
ParserFactory::createForHostVersion()is used to create a parser matching the current PHP version. Older versions use the same code as before usingParserFactory::PREFER_PHP_7.I tested it using a fresh Laravel installation with
nikic/php-parser4.x and 5.x respectively and both succeeded without any issues.