Skip to content

Conversation

zupolgec
Copy link
Contributor

Fixes #5

There is a bug in Laravel (laravel/framework#17283) that prevents Mailable with callbacks to be serialized for queueing.

So when a Mailable implements ShouldQueue we don't add headers.

Also changed the check from MailableContract to Mailable since the applyDebugHeaders function expects a Mailable (that has a view property).

@jasonvarga
Copy link

Doesn't this just remove the debug feature for queued mail?

@zupolgec
Copy link
Contributor Author

Yes, because this feature is not available on queued Mailables.
This package could provide a modified HeloMailable to extend, but what is the point of debugging locally the content of enqueued Mailables?

@sebwas
Copy link

sebwas commented Dec 8, 2020

Why has this not been merged yet? @mpociot

@mpociot mpociot merged commit bca9d97 into beyondcode:master May 11, 2021
@mpociot
Copy link
Member

mpociot commented May 11, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants