Fix non-srgb RenderTarget::Image #22090
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22031 (comment). Fixes #15201.
#22031 makes
ViewTarget::out_texture_formatto return the underlying texture’s format, which causes some issues:ExtractedWindow::swap_chain_texture_viewalways uses srgb view. But the underlying swap chain texture in WebGPU can be Bgra8unorm, leading to format mismatch between the render pipeline and the render pass.Solution
Reverts #22031.
Renames some
formattoview_formatexplicitly.Adds
view_formattoGpuImageandImage::new_target_textureso we can make render pipeline match render pass texture view.Testing
Tested
render_to_textureandscreenshotexamples on linux and webgpu.The rendered Rgba8Unorm texture with or without srgb view in MeshMaterial3d looks the same, but the underlaying data is different:
With srgb view:

Without srgb view:
