Don't use [!Default; 0]: Default impl #21660
Merged
+2 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alice-i-cecile approved these changes Oct 26, 2025
alice-i-cecile added A-ECS 
| Thanks Waffle :) This seems perfectly fine for us: I appreciate you PR'ing this! |
| We should discuss if we want to backport this PR to previous Bevy versions too. Being able to compile old versions of Bevy with new compilers is nice. I think that the offending code is relatively new. |
janhohenheim approved these changes Oct 26, 2025
janhohenheim added D-Trivial 
mockersf approved these changes Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Objective
where T: DefaulttoDefault for [T; 0]impl. rust-lang/rust#145457, we want to remove unconditional[T; 0]: Defaultimpl. That would be a breaking change breakingbevy_ecsand (a test of)bevy_camera.Solution
<[T; 0]>::default()calls with[]Testing
<[T; 0]>::default()is equivalent to[], no additional testing required