Skip to content

Conversation

codecae
Copy link
Member

@codecae codecae commented Nov 17, 2017

No description provided.

README.md Outdated
### How to download the scripts

[Click here](http://null.eastus.cloudapp.azure.com/job/Betaflight%20Lua%20-%20X7,%20X9,%20X9D,%20X9D+/lastSuccessfulBuild/artifact/obj/SCRIPTS/*zip*/SCRIPTS.zip) to download a zip file containing latest version.
[Click here](http://null.eastus.cloudapp.azure.com/job/Betaflight%20Lua%20-%20X7,%20X9,%20X9D,%20X9D+/lastSuccessfulBuild/artifact/obj/*zip*/obj.zip) to download a zip file containing latest version.
Copy link
Member

@mikeller mikeller Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to get away from asking users to install the latest nightly, and start doing proper releases. So instead of putting more lipstick onto this pig, I suggest we take what we've got now, and make release 0.1 from it!

Correction: I just realised that you actually did a release. The readme (and all other places talking about the betaflight-tx-lua-scripts) should totally point to the releases page now, and I think we should do another one, now that the background task / crossfire incompatibility has been sorted.

Correction 2: I just realised that the link to the 'releases' page in the Jenkins that the readme is pointing to actually points to codecae/betaflight-tx-lua-revised, and the release you did is there. This is beyond confusing. Can you please do a release (once Jenkins has picked up #87), and then change the link in Jenkins to point to the correct releases page?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely... I was hoping by now we'd be on ci.betaflight.tech, but I will make the changes there. I'm having to push these changes to my fork in order to update Jenkins, which is kind of kludgy.

Should we tag the release in the correct repo and I'll create the release from that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's where the release should go, and where all of the documentation should be pointing to: https://github.com/betaflight/betaflight-tx-lua-scripts/releases

If we are not ready yet to use http://ci.betaflight.tech/ to do release builds, using your Jenkins on azure is still better than using a local build, and I think right now, getting a release out and starting to get users used to using releases instead of latest builds is better than keeping them pulling from Jenkins, and getting all upset if something is broken.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.0 has been released based on #87. I have updated the commentary on jenkins, as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all that is left to be done is to update the readme to tell the users to go and get the release. 😃

@codecae codecae force-pushed the update_download_link branch from a9f5c12 to 55dfd48 Compare November 17, 2017 22:38
@codecae codecae force-pushed the update_download_link branch from 55dfd48 to 32822e3 Compare November 17, 2017 22:39
@codecae codecae changed the title Updated link to include /BF in zip for horus users Updated link to direct users to the releases page for downloads Nov 17, 2017
@codecae
Copy link
Member Author

codecae commented Nov 18, 2017 via email

@mikeller mikeller merged commit 5e9b26f into betaflight:master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants