-
- Notifications
You must be signed in to change notification settings - Fork 155
Updated link to direct users to the releases page for downloads #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md Outdated
### How to download the scripts | ||
| ||
[Click here](http://null.eastus.cloudapp.azure.com/job/Betaflight%20Lua%20-%20X7,%20X9,%20X9D,%20X9D+/lastSuccessfulBuild/artifact/obj/SCRIPTS/*zip*/SCRIPTS.zip) to download a zip file containing latest version. | ||
[Click here](http://null.eastus.cloudapp.azure.com/job/Betaflight%20Lua%20-%20X7,%20X9,%20X9D,%20X9D+/lastSuccessfulBuild/artifact/obj/*zip*/obj.zip) to download a zip file containing latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really need to get away from asking users to install the latest nightly, and start doing proper releases. So instead of putting more lipstick onto this pig, I suggest we take what we've got now, and make release 0.1 from it!
Correction: I just realised that you actually did a release. The readme (and all other places talking about the betaflight-tx-lua-scripts) should totally point to the releases page now, and I think we should do another one, now that the background task / crossfire incompatibility has been sorted.
Correction 2: I just realised that the link to the 'releases' page in the Jenkins that the readme is pointing to actually points to codecae/betaflight-tx-lua-revised, and the release you did is there. This is beyond confusing. Can you please do a release (once Jenkins has picked up #87), and then change the link in Jenkins to point to the correct releases page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely... I was hoping by now we'd be on ci.betaflight.tech, but I will make the changes there. I'm having to push these changes to my fork in order to update Jenkins, which is kind of kludgy.
Should we tag the release in the correct repo and I'll create the release from that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's where the release should go, and where all of the documentation should be pointing to: https://github.com/betaflight/betaflight-tx-lua-scripts/releases
If we are not ready yet to use http://ci.betaflight.tech/ to do release builds, using your Jenkins on azure is still better than using a local build, and I think right now, getting a release out and starting to get users used to using releases instead of latest builds is better than keeping them pulling from Jenkins, and getting all upset if something is broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1.0 has been released based on #87. I have updated the commentary on jenkins, as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now all that is left to be done is to update the readme to tell the users to go and get the release. 😃
a9f5c12
to 55dfd48
Compare 55dfd48
to 32822e3
Compare The latest amend has an update for the readme …On Nov 17, 2017 7:11 PM, "Michael Keller" ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In README.md <#88 (comment)> : > @@ -2,7 +2,7 @@ ### How to download the scripts -[Click here](http://null.eastus.cloudapp.azure.com/job/Betaflight%20Lua%20-%20X7,%20X9,%20X9D,%20X9D+/lastSuccessfulBuild/artifact/obj/SCRIPTS/*zip*/SCRIPTS.zip) to download a zip file containing latest version. +[Click here](http://null.eastus.cloudapp.azure.com/job/Betaflight%20Lua%20-%20X7,%20X9,%20X9D,%20X9D+/lastSuccessfulBuild/artifact/obj/*zip*/obj.zip) to download a zip file containing latest version. Now all that is left to be done is to update the readme to tell the users to go and get the release. 😃 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#88 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHyTqWihfO5uyR2DRxA5IrT-ByemYsr8ks5s3iCXgaJpZM4QiEcr> . |
No description provided.