Add 'Retrying' popup, etc #56
Closed
+23 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show 'Retrying' if save-retry happens Put in code for showing debug info during save (commented out) Fixed 'processMspReply()' handing of case where EEPROM_WRITE not done Made general timeout 3 seconds Added 'mspGetLastReqValue()' fn to 'msp_sp.lua' Set VTX-page 'saveMaxRetries' to 1
| This repository has been rebased on the more advanced https://github.com/codecae/betaflight-tx-lua-revised. Please update your pull request if it is still relevant, or close it otherwise. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Shows 'Retrying' if save-retry happens. Fixed 'processMspReply()' handing of case where EEPROM_WRITE not done. Made general timeout 3 seconds and changed VTX-page 'saveMaxRetries' from 0 to 1. Added 'mspGetLastReqValue()' fn to 'msp_sp.lua'.
I'm seeing issues with the reliability of the save-page command and response. With the new code for the 'Retrying' message in place you can see when the transaction fails and repeats. Without this, and with shorter timeouts (and no retries on VTX page) I think these transaction failures have been less noticeable.
The background thread doing extra calls to 'mspSendRequest()' makes it worse, as these can interfere with the transactions in "ui.lua". I think there needs to be some kind of flagging or queuing. But even with an older version of the scripts (i.e., here) I still see retries happening all the time. My test setup is Taranis X7, XSR receiver, BF 'master' as of 2017-11-11.
I left some comment-out code at the end of 'run_ui()' that may be useful for debugging.
--ET