Handle signed values #458
Merged
Handle signed values #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
haslinghuis previously approved these changes Nov 13, 2022
haslinghuis reviewed Nov 13, 2022
src/SCRIPTS/BF/ui.lua Outdated
| end | ||
| local bits = #f.vals * 8 | ||
| if f.min < 0 and bit32.btest(f.value, bit32.lshift(1, bits - 1)) then | ||
| f.value = f.value - math.pow(2, bits) |
There was a problem hiding this comment.
Suggested change
| f.value = f.value - math.pow(2, bits) | |
| f.value = f.value - (2 ^ bits) |
klutvott123 force-pushed the handle-signed-values branch from ad61fb3 to 138c7d4 Compare haslinghuis approved these changes Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently we're treating all incoming values as unsigned.
This PR adds detection of signed values by checking the fields min limit