VTX memory savings #284
Merged
VTX memory savings #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mikeller previously approved these changes Nov 11, 2019
frozenskys suggested changes Nov 12, 2019
klutvott123 force-pushed the vtx-memory-savings branch from 3e9d67d to 1ed2aa6 Compare 
| @frozenskys Done! |
| @klutvott123 looks good - did you see @mikeller's comments on betaflight/betaflight-configurator#1822 ? What does everyone think? |
Have vtx_defaults return it's tables to vtx instead of loading them as globals.
klutvott123 force-pushed the vtx-memory-savings branch from 1ed2aa6 to f2d46e3 Compare | @frozenskys I just moved |
| @klutvott123 looks spot on.. Thanks for your help on this... |
mikeller approved these changes Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Have vtx_defaults.lua/modelname.lua return their tables to vtx.lua instead of using globals. This prevents the tables that are specific only to vtx.lua to be loaded all the time. Should save between 1 and 2k of memory when the vtx page is not selected.