Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Makes Page, backgroundFill, foregroundColor and globalTextOptions local to ui.lua. Removes the global variables from horuspre.lua and does the assignment in ui.lua.
I have noticed that global variables use a bit more memory than local variables. All of these variables are only used in
ui.lua
and can be made local. I'm printingcollectgarbage("count")
at the end ofrun_ui()
on my QX7 and the total lua memory usage is about 1KB lower. The opentx statistics screen shows that "Free mem" is roughly 2-3KB higher than before which I believe indicates that peak memory usage is also reduced.Also did some indentation fixes.