Updated ui.lua to better handle incompatible API versions #207
Conversation
| For some reason my amend didn't work.. trying again. |
| Page = assert(loadScript(radio.templateHome .. PageFiles[currentPage]))() | ||
| if Page.requiredVersion and apiVersion > 0 then | ||
| if Page.requiredVersion > apiVersion then | ||
| PageFiles[currentPage] = nil |
There was a problem hiding this comment.
This will cause problems if users are using multiple craft with different firmware versions with the same TX side model, and do not power cycle their TX in between.
There was a problem hiding this comment.
Someone would be required to power cycle or change models anyway if they want to obtain the API version, too. The init function only runs once at the time of initial invocation, so there's a possibility that the API version retained in memory might not match the new FC. If they do match, though, the same set of pages would still be compatible.
There was a problem hiding this comment.
The init function runs every time a connection is established. As a consequence, the API version will be queried again after models have been changed.
There was a problem hiding this comment.
I got the init functions confused I think... apologies.
There was a problem hiding this comment.
Maybe re-seed the pages here?
betaflight-tx-lua-scripts/src/SCRIPTS/BF/background.lua
Lines 42 to 46 in 62d7d4a
There was a problem hiding this comment.
Sounds like a lot of complexity for not much gain, compared to what I have proposed in #203.
But adding the graceful exit makes sense.
Hoping this will help with API mismatches and prevent infinite loops of
run_ui.