Update ui.lua #200
Closed
Update ui.lua #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mikeller requested changes Mar 24, 2019
| | ||
| local function invalidatePages() | ||
| Page = nil | ||
| dataInitialised = false |
There was a problem hiding this comment.
This shouldn't be invalidated - no point in re-reading data over and over again, especially as bandwidth is already scarce.
| if data_init == nil then | ||
| data_init = assert(loadScript(SCRIPT_HOME .. "/data_init.lua"))() | ||
| end | ||
| dataInitialised = data_init.init(); |
There was a problem hiding this comment.
Why are you running this only once? If you want to run this here, it should be run until the initialisation has finished, otherwise this will just be done after an arbitrary number of user interactions.
| @mikeller still not working with latest ui.lua data is not initialized and apiversion remain 0. At leastr with X9D is not working. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In order to fix issue 199 where api version is not initialized correctly the pull request is tested.
#199