Skip to content

Round value when updating vals #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2018
Merged

Round value when updating vals #192

merged 1 commit into from
Dec 21, 2018

Conversation

klutvott123
Copy link
Member

Found that in some cases it's not enough to just round f.value. For example when setting rc rate to 2.05 and saving i would get 2.04 back. When updating vals, errors seem to be multiplied when doing f.value*scale, so it should be rounded there too.

Also gave f.mult or 1 its own variable since f.scale or 1 already has one.
@mikeller mikeller merged commit 859cb77 into betaflight:master Dec 21, 2018
@klutvott123 klutvott123 deleted the Improve-rounding branch November 15, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@klutvott123 @mikeller