changed layout of PIDs and Rates to make it look more like as in beta…

[JR63]

Hi,

I adapted the script for X7 to make it looking a little bit more like the original betaflight layout.

The small change in ui.lua will only affect the X7 and X9, it is needed for smaller size characters.

So we have Roll, Pitch, Yaw as rows on both pages.

The P, I, D values come as columns on the PIDs Page.

The RC Rate, Super Rate, RC Expo values come in a smaller type and as columns in the same order as in betaflight on the Rates Page.

The VTX page is unchanged.

I tested it in companion and on a real Taranis Q X7 with SPRacingF3 running betaflight and FrSky X4RSB.

Betaflight / SPRACINGF3 3.1.5 Feb 7 2017 / 22:30:44 (4646f9d)

Bye
JR

[raphaelcoeffic]

@JR63 Looks really cool! I'll give it a shot ASAP, and merge if everything is ok.

[JR63]

@raphaelcoeffic That sounds good. Thanks.

[JR63]

@raphaelcoeffic
By the way: I can do the same for X9 and maybe for Horus.
But I can only test with companion because I only own a real X7.

[raphaelcoeffic]

On 21 Feb 2017, at 17:00, JR63 ***@***.***> wrote: @raphaelcoeffic <https://github.com/raphaelcoeffic> By the way: I can do the same for X9 and maybe for Horus. But I can only test with companion because I only own a real X7.

Sounds good to me! I can test on X9 and I know somebody for the Horus. In fact, we could even have some bitmaps for these targets ;-)

[JR63]

@raphaelcoeffic
Ok, I did it for X9 and Horus and checked both with companion.
Because all 3 uses the same indexing (by variable i) I'm quite shure it will work for X7, X9 and Horus because I tested it with the X7.

[JR63]

And here are the screen shots for X9 and Horus:

[si618]

Thanks @JR63, I've closed my PR for the X9 change.

[ronerone]

displays correctly here, BF3.1.5, open tx 2.2 RC10 on taranis + with last released script modified to reflect your changes.

[JR63]

Many thanks for your testing.

[si618]

+1 for @JR63 changes, tested pid and rate pages on my x9+; working well and looking good!

[JR63]

Cool, thanks to you also.

[SoulPictures]

Seems to work fine on a physical Horus with RC10, no visible glitches

[JR63]

Cool, thanks for testing on Horus.

[raphaelcoeffic]

@JR63 Thx a lot for the work! I think we're good to merge now.

[JR63]

That sounds very good. Many thanks to all.

[raphaelcoeffic]

New release has been pushed (v0.3) to make the changes available.

[ronerone]

mmh! had a weird issue in iu.lua while navigating the screen pages (in the tramp page) after flying. an error on line 238 if i remember well.
I restarted the taranis and it was ok.
I'm sorry i couldn't write somewhere the exact line and message, but it was probably in function drawMenu.
I'll try to take a picture if it appears again.
For the time being, i keep the 0.2 version i modified which i think should be the same as v0.3.

[JR63]

Hi,
This pull request did'nt changed the vtx pages.
So, if your issue can be reproduced with the newest code, I suggest to open an issue on the main project page, thanks.

[ronerone]

hi JR63? no problem. i was suspecting an issue due to the fact i had manually added the code to 0.2 version, which i may have uncorrectly made. I'll check later if i reproduce.
Thanks to all for your improvements!