Skip to content

refactor(core): set vue flow version as regular string instead of ref #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcakmakoglu merged 2 commits into from
Apr 24, 2023
Merged

refactor(core): set vue flow version as regular string instead of ref #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c4073b
refactor(core): set vue flow version as regular string instead of ref
bcakmakoglu Apr 24, 2023
3b07090
chore(changeset): add
bcakmakoglu Apr 24, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-socks-try.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@vue-flow/core": patch
---

Set vue flow version as regular string instead of a ref
1 change: 1 addition & 0 deletions packages/core/src/composables/useVueFlow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export class Storage {
...toRefs(reactiveState),
emits,
id,
vueFlowVersion: typeof __VUE_FLOW_VERSION__ !== 'undefined' ? __VUE_FLOW_VERSION__ : 'UNKNOWN',
$destroy: () => {
this.remove(id)
},
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/store/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,6 @@ function defaultState(): State {
__experimentalFeatures: {
nestedFlow: false,
},

vueFlowVersion: typeof __VUE_FLOW_VERSION__ !== 'undefined' ? __VUE_FLOW_VERSION__ : '-',
}
}

Expand Down
5 changes: 2 additions & 3 deletions packages/core/src/types/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,6 @@ export interface State extends Omit<FlowOptions, 'id' | 'modelValue'> {
disableKeyboardA11y: boolean

ariaLiveMessage: string

/** current vue flow version you're using */
readonly vueFlowVersion: string
}

export type SetElements = (elements: Elements | ((elements: FlowElements) => Elements)) => void
Expand Down Expand Up @@ -311,6 +308,8 @@ export type ComputedGetters = {
export type VueFlowStore = {
readonly id: string
readonly emits: FlowHooksEmit
/** current vue flow version you're using */
readonly vueFlowVersion: string
} & FlowHooksOn &
ToRefs<State> &
Readonly<ComputedGetters> &
Expand Down