Skip to content

Conversation

rickeylev
Copy link
Collaborator

With some core Bazel changes to flags coming that will affect us, and the difficulty it
is to keep the bazel-at-head-and-downstream pipeline green, I figured it'd be a good idea
to add a CI job that uses the weekly Bazel release so we can identify problems sooner
and more obviously.

The CI job only run on Ubuntu to save CI slots and is won't block merges if it has failures.

@rickeylev rickeylev requested a review from aignas as a code owner September 16, 2025 02:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new, non-blocking continuous integration job designed to proactively identify potential compatibility issues with upcoming core Bazel changes. By running tests against the weekly "rolling" Bazel release on an Ubuntu platform, this advisory job aims to provide early warnings without impeding the merge process, thereby helping to maintain a stable bazel-at-head-and-downstream pipeline.

Highlights

  • New CI Job for Bazel Rolling: A new CI job named "ubuntu_rolling" has been added to the .bazelci/presubmit.yml configuration.
  • Weekly Bazel Release: This new job is configured to run tests against the weekly "rolling" Bazel release, allowing for early detection of compatibility issues with core Bazel changes.
  • Non-Blocking Execution: The ubuntu_rolling job is set as soft_fail, meaning it will not block merges even if it encounters failures, serving as an advisory check.
  • Ubuntu Platform: To conserve CI resources, this job is specifically configured to run only on the ubuntu2204 platform.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a non-blocking CI job for Bazel rolling releases, which is a proactive measure to catch potential issues early. The configuration is well-structured, but I've identified a significant oversight in the soft_fail settings. Currently, it only handles build failures, meaning test failures would still block merges, which contradicts the goal of this change. My review includes a specific suggestion to correct this to ensure the job behaves as an advisory one in all failure scenarios.

@rickeylev rickeylev enabled auto-merge September 16, 2025 03:24
@rickeylev rickeylev added this pull request to the merge queue Sep 16, 2025
Merged via the queue into bazel-contrib:main with commit 77cf48d Sep 16, 2025
4 checks passed
@rickeylev rickeylev deleted the chore.rolling.ci branch September 16, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants