Skip to content

Conversation

rickeylev
Copy link
Collaborator

I found it was doing a very poor job, so some guidance is needed.

@rickeylev rickeylev requested a review from aignas as a code owner September 10, 2025 17:09
@rickeylev rickeylev requested a review from groodt September 10, 2025 17:09
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the AGENTS.md documentation by providing crucial guidelines for managing Bazel build configurations. It introduces clear instructions for creating and structuring bzl_library targets for .bzl source files and clarifies the usage of buildifier disable comments for visibility issues in test-related build files. These updates aim to improve consistency and correctness in Bazel rule definitions across the codebase.

Highlights

  • bzl_library target guidance: New instructions added for defining bzl_library targets for .bzl files, including naming conventions, srcs and deps rules, and alphabetical insertion.
  • bzl-visibility disable comments: Guidance added for using # buildifier: disable=bzl-visibility comments in BUILD and .bzl files under tests/ when loading from /private/ paths.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds valuable guidance for AI agents on creating bzl_library targets and handling private dependencies in tests. The new instructions are clear and will help improve the quality of automated changes. I've included a couple of minor suggestions to further enhance the clarity of the new documentation.

rickeylev and others added 2 commits September 10, 2025 15:43
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rickeylev rickeylev added this pull request to the merge queue Sep 11, 2025
Merged via the queue into bazel-contrib:main with commit 35adf5c Sep 11, 2025
4 checks passed
@rickeylev rickeylev deleted the chore.agents branch September 11, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants