fix(gazelle) Fix dependency added as both deps and pyi_deps #3036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dougthor42 approved these changes Jun 28, 2025
gazelle/python/testdata/type_checking_imports_across_packages/a/bar.py Outdated Show resolved Hide resolved
dougthor42 approved these changes Jun 29, 2025
amartani added a commit to benchling/rules_python that referenced this pull request Jul 8, 2025
…ntrib#3036) Fix an issue in bazel-contrib#3014 where a dependency may end up being added in both `deps` and `pyi_deps`, in cases where the regular and the type-checking import refer to different python modules on the same `py_library` target. Other cases are already deduplicated earlier on, but this case can only be deduplicated in the resolve phase. (No new changelog entry since this is a fix to an unreleased feature that is already in the changelog)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix an issue in #3014 where a dependency may end up being added in both
depsandpyi_deps, in cases where the regular and the type-checking import refer to different python modules on the samepy_librarytarget. Other cases are already deduplicated earlier on, but this case can only be deduplicated in the resolve phase.(No new changelog entry since this is a fix to an unreleased feature that is already in the changelog)