read(): Don't ignore "frames" argument #214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mgeier force-pushed the frames-and-out2 branch from f3a08f2 to eb422f8 Compare Partial solution to bastibe#210, but this breaks blocks()! The tests can be run without testing blocks(): python3 -m pytest -k"not blocks"
mgeier force-pushed the frames-and-out2 branch from eb422f8 to 1a7b87e Compare 
| What is the status of this pull request? |
| This is still open but it can only be merged after You could cherry-pick the first commit, though. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a partial solution to #210, but currently this breaks
blocks()(because that relies on the previous strange behavior)!For now, the tests can be run without testing blocks():