Add missing nodes warning + grammar update #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mads-hartmann approved these changes Sep 11, 2018
| @skovhus I'll merge and release tomorrow 👍 |
| I've sneaked in a small upgrade of the grammar in this PR. 😊 |
skovhus changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #74
Currently, the extension is just silent if a node is missing, but this PR adds an error to the bottom of a file if a node is missing.
Unfortunately, we cannot show the missing node where it occurs... So we should evaluate if this PR gives any additional value. See tree-sitter/tree-sitter-bash#30
Besides, I'm bumping the version number and increase the required server version to the current release (a lot are probably using an old version).