Glob in non-strict mode #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This allows directories without access to be on the given path. E.g. mkdir directory-without-access && sudo chown root:staff directory-without-access && sudo chmod 600 directory-without-access
| Upstream fix: isaacs/node-glob#413 |
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server: 1.13.1 Gracefully handle glob failures (bash-lsp/bash-language-server#224, bash-lsp/bash-language-server#226) Maintenance (bash-lsp/bash-language-server#222, bash-lsp/bash-language-server#225) 1.13.0 Upgrade vscode-languageserver from 5 to 6 (bash-lsp/bash-language-server#217) 1.12.0 Completion handler improvements: remove duplicates, include symbols from other files, ensure that programs found on the paths are actually executable (bash-lsp/bash-language-server#215) 1.11.3 Recover from file reading errors (bash-lsp/bash-language-server#211) Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server: 1.13.1 Gracefully handle glob failures (bash-lsp/bash-language-server#224, bash-lsp/bash-language-server#226) Maintenance (bash-lsp/bash-language-server#222, bash-lsp/bash-language-server#225) 1.13.0 Upgrade vscode-languageserver from 5 to 6 (bash-lsp/bash-language-server#217) 1.12.0 Completion handler improvements: remove duplicates, include symbols from other files, ensure that programs found on the paths are actually executable (bash-lsp/bash-language-server#215) 1.11.3 Recover from file reading errors (bash-lsp/bash-language-server#211) Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request Apr 21, 2020
Changelog of the server: 1.13.1 Gracefully handle glob failures (bash-lsp/bash-language-server#224, bash-lsp/bash-language-server#226) Maintenance (bash-lsp/bash-language-server#222, bash-lsp/bash-language-server#225) 1.13.0 Upgrade vscode-languageserver from 5 to 6 (bash-lsp/bash-language-server#217) 1.12.0 Completion handler improvements: remove duplicates, include symbols from other files, ensure that programs found on the paths are actually executable (bash-lsp/bash-language-server#215) 1.11.3 Recover from file reading errors (bash-lsp/bash-language-server#211) Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
akurtakov added a commit to akurtakov/shellwax that referenced this pull request May 27, 2020
Language server changelog: 1.16.1 Fix brace expansion bug (bash-lsp/bash-language-server#240) Do not crash if bash is not installed (bash-lsp/bash-language-server#242) 1.16.0 Improved completion handler for parameter expansions (bash-lsp/bash-language-server#237) 1.15.0 Use comments above symbols for documentation (bash-lsp/bash-language-server#234, bash-lsp/bash-language-server#235) 1.14.0 onHover and onCompletion documentation improvements (bash-lsp/bash-language-server#230) support 0/1 as values for HIGHLIGHT_PARSING_ERRORS (bash-lsp/bash-language-server#231) 1.13.1 Gracefully handle glob failures (bash-lsp/bash-language-server#224, bash-lsp/bash-language-server#226) Maintenance (bash-lsp/bash-language-server#222, bash-lsp/bash-language-server#225) Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request May 27, 2020
Language server changelog: 1.16.1 Fix brace expansion bug (bash-lsp/bash-language-server#240) Do not crash if bash is not installed (bash-lsp/bash-language-server#242) 1.16.0 Improved completion handler for parameter expansions (bash-lsp/bash-language-server#237) 1.15.0 Use comments above symbols for documentation (bash-lsp/bash-language-server#234, bash-lsp/bash-language-server#235) 1.14.0 onHover and onCompletion documentation improvements (bash-lsp/bash-language-server#230) support 0/1 as values for HIGHLIGHT_PARSING_ERRORS (bash-lsp/bash-language-server#231) 1.13.1 Gracefully handle glob failures (bash-lsp/bash-language-server#224, bash-lsp/bash-language-server#226) Maintenance (bash-lsp/bash-language-server#222, bash-lsp/bash-language-server#225) Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Run glob in non-strict mode to recover from errors (e.g. permission issues).
Originally, it looked like we were already running in non-strict mode. But the documentation for node-glob could be made more clear (isaacs/node-glob#298).
Related: #224 #223 isaacs/node-glob#413