Added an iOS and Android bridge to the BatchPush.getLastKnownPushToke… #16
Conversation
Minishlink left a comment
Minishlink left a comment There was a problem hiding this comment.
Thanks for your contribution! :) Can you review my comments?
| @@ -1,16 +1,16 @@ | |||
| { | |||
| "name": "react-native-batch-push", | |||
| | ||
| @ReactMethod | ||
| public void lastKnownPushToken(Promise promise) { | ||
| try{ |
There was a problem hiding this comment.
Why catching an error on Android but not on iOS?
| ``` | ||
| | ||
| ### Last known push token | ||
| |
There was a problem hiding this comment.
Please add a warning that this should only be used for debugging - the correct way in production would be to use a listener
There was a problem hiding this comment.
It is my understanding that Batch already implements a listener and stores the push token when it changes. Why add one more listener on top of that?
There was a problem hiding this comment.
I'm only referencing what states in the doc :) It looks like we shouldn't rely too much on this value.
This method will return null if no registration identifier has been fetched or if Batch isn't started, meaning that you have to call this method after Batch.onStart(). It is useful if you want to show the token in your UI, for example in a debug view.
There was a problem hiding this comment.
This (annoying) limitation is exactly why we introduced the listener down the road: users had to work around the token not being available with something like setTimeout.
The listener also gives you the token provider (GCM/FCM, and possibly more in the future)
My 2cts is that both can be used: they're not meant for the same use cases.
4 participants
No description provided.