Skip to content

Conversation

@alanb128
Copy link
Contributor

@alanb128 alanb128 commented Jul 1, 2025

This PR changes the base image from balenalib to the official node image.

Other features/files that depend on balenalib have also been updated.

Tested on Pi 3b+, 4, 5, and x86.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@phil-d-wilson
Copy link
Contributor

@alanb128 I think the deploy job on the pipeline hasn't been updated to the current location of the block

@alanb128
Copy link
Contributor Author

alanb128 commented Jul 1, 2025

Thanks @phil-d-wilson I will seek out some assistance for that...

As far as testing, I've done, GPU/no GPU, Kiosk, and HTTP API calls on Pi 3/4/5/x86. Anything else you suggest checking?

@phil-d-wilson
Copy link
Contributor

phil-d-wilson commented Jul 1, 2025 via email

@alanb128
Copy link
Contributor Author

alanb128 commented Jul 3, 2025

@phil-d-wilson I've confirmed YouTube and WebGL and it looks good, except on the Pi 3 - but no worse than the Pi 3 looks using the current browser version. For the "GPU page" are you referring to confirming GPU via curl http://localhost:5011/gpu ?

@phil-d-wilson
Copy link
Contributor

phil-d-wilson commented Jul 3, 2025 via email

@tim-littlefair
Copy link

The version of entry.sh created by this commit:
961645c
doesn't look right to me - it looks like a Dockerfile rather than a shell script.

I'm guessing that the right content should be more like the entry.sh in one or other of the older balenalib base images, e.g.
https://github.com/balena-io-library/base-images/blob/master/balena-base-images/aarch64/debian/bookworm/build/entry.sh.

Or am I missing something?

@alanb128
Copy link
Contributor Author

Good catch @tim-littlefair that must have gotten overwritten at some point. It has been updated and tested.

tim-littlefair added a commit to tim-littlefair/tl-balena-browser that referenced this pull request Jul 17, 2025
PR reference: balena-io-experimental#185 This change tested and working as expected in RP3-64
@flowzone-app flowzone-app bot enabled auto-merge July 22, 2025 15:04
@vipulgupta2048
Copy link
Member

@klutchell I wanted to add a comment for the future still, would you recommend commenting the section instead.
This is because it's a block and it would be given that it's publishing to balenahub until explicitly said otherwise

alanb128 and others added 3 commits July 22, 2025 20:52
Change-type: minor Signed-off-by: Alan Boris <alan@balena.io>
Change-type: patch Signed-off-by: Alan Boris <alan@balena.io>
Copy link
Member

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Didn't know the policy got changed to folks changing commits can also do approvals.

@flowzone-app flowzone-app bot merged commit d4a8a0d into master Jul 22, 2025
46 checks passed
@flowzone-app flowzone-app bot deleted the alanb128-un-balenalib branch July 22, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants