- Notifications
You must be signed in to change notification settings - Fork 94
Remove balenalib and dependencies #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| @alanb128 I think the deploy job on the pipeline hasn't been updated to the current location of the block |
| Thanks @phil-d-wilson I will seek out some assistance for that... As far as testing, I've done, GPU/no GPU, Kiosk, and HTTP API calls on Pi 3/4/5/x86. Anything else you suggest checking? |
| Did you try videos (YouTube) and WebGL? And look at the gpu page to check hardware acceleration is enabled? …On Tue, 1 Jul 2025, 19:56 Alan Boris, ***@***.***> wrote: *alanb128* left a comment (balena-io-experimental/browser#185) <#185 (comment)> Thanks @phil-d-wilson <https://github.com/phil-d-wilson> I will seek out some assistance for that... As far as testing, I've done, GPU/no GPU, Kiosk, and HTTP API calls on Pi 3/4/5/x86. Anything else you suggest checking? — Reply to this email directly, view it on GitHub <#185 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJM2RNCYLBXWP5SL3TCQKCT3GLKVNAVCNFSM6AAAAACARRHLICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMRVGE3TSMBQHA> . You are receiving this because you were mentioned.Message ID: ***@***.***> |
| @phil-d-wilson I've confirmed YouTube and WebGL and it looks good, except on the Pi 3 - but no worse than the Pi 3 looks using the current browser version. For the "GPU page" are you referring to confirming GPU via |
| Yep, that should show that hardware acceleration is enabled …On Thu, 3 Jul 2025, 19:36 Alan Boris, ***@***.***> wrote: *alanb128* left a comment (balena-io-experimental/browser#185) <#185 (comment)> @phil-d-wilson <https://github.com/phil-d-wilson> I've confirmed YouTube and WebGL and it looks good, except on the Pi 3 - but no worse than the Pi 3 looks using the current browser version. For the "GPU page" are you referring to confirming GPU via curl http://localhost:5011/gpu ? — Reply to this email directly, view it on GitHub <#185 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJM2RNH24C5FBRDCM2ESMYD3GVZ4TAVCNFSM6AAAAACARRHLICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMZTGE4TKOJXGY> . You are receiving this because you were mentioned.Message ID: ***@***.***> |
| The version of entry.sh created by this commit: I'm guessing that the right content should be more like the entry.sh in one or other of the older balenalib base images, e.g. Or am I missing something? |
| Good catch @tim-littlefair that must have gotten overwritten at some point. It has been updated and tested. |
PR reference: balena-io-experimental#185 This change tested and working as expected in RP3-64
| @klutchell I wanted to add a comment for the future still, would you recommend commenting the section instead. |
Change-type: minor Signed-off-by: Alan Boris <alan@balena.io>
Change-type: patch Signed-off-by: Alan Boris <alan@balena.io>
8bda999 to 01521a0 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Didn't know the policy got changed to folks changing commits can also do approvals.
This PR changes the base image from balenalib to the official node image.
Other features/files that depend on balenalib have also been updated.
Tested on Pi 3b+, 4, 5, and x86.